Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new database backends #427

Merged
merged 8 commits into from Apr 16, 2020
Merged

Use new database backends #427

merged 8 commits into from Apr 16, 2020

Conversation

hadley
Copy link
Member

@hadley hadley commented Apr 15, 2020

Fixes #423

@hadley hadley requested a review from krlmlr Apr 15, 2020
krlmlr
krlmlr approved these changes Apr 16, 2020
Copy link
Member

@krlmlr krlmlr left a comment

Looks good, tests pass locally. I removed a stray warning.

Do you intend to get rid of withr? The dependency is there, never used until now.

@hadley hadley merged commit 1a0791d into master Apr 16, 2020
12 checks passed
@hadley
Copy link
Member Author

@hadley hadley commented Apr 16, 2020

Thanks — I will eliminate withr since we don't need it

@hadley hadley deleted the backend-update branch Apr 16, 2020
@hadley
Copy link
Member Author

@hadley hadley commented Apr 16, 2020

(Thanks for spotting that open connection; it had been bothering me for a while but I never had the heart to run down the source)

@hadley hadley mentioned this pull request Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants