New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed VARCHAR to VARCHAR2 #66

Merged
merged 5 commits into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@washcycle
Copy link
Contributor

washcycle commented Feb 12, 2018

Per

VARCHAR Datatype
Do not use the VARCHAR datatype. Use the VARCHAR2 datatype instead. Although the VARCHAR datatype is currently synonymous with VARCHAR2, the VARCHAR datatype is scheduled to be redefined as a separate datatype used for variable-length character strings compared with different comparison semantics.

https://docs.oracle.com/cd/B19306_01/server.102/b14200/sql_elements001.htm

Changed VARCHAR to VARCHAR2
Per

```
VARCHAR Datatype
Do not use the VARCHAR datatype. Use the VARCHAR2 datatype instead. Although the VARCHAR datatype is currently synonymous with VARCHAR2, the VARCHAR datatype is scheduled to be redefined as a separate datatype used for variable-length character strings compared with different comparison semantics.
```

https://docs.oracle.com/cd/B19306_01/server.102/b14200/sql_elements001.htm
@hadley

This comment has been minimized.

Copy link
Member

hadley commented Jun 7, 2018

Can you please update the tests too?

updated oracle test
updated oracle test with VARCHAR2
@washcycle

This comment has been minimized.

Copy link
Contributor

washcycle commented Jun 9, 2018

Done. Let me know if there is anything else. Or if this wasn't want you meant.

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Jun 9, 2018

Looks good, thanks! To finish it off, can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

washcycle and others added some commits Jun 9, 2018

@hadley hadley merged commit be7f5e9 into tidyverse:master Jan 2, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@hadley

This comment has been minimized.

Copy link
Member

hadley commented Jan 2, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment