Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing con argument in sql_render.op() #73

Merged
merged 5 commits into from Jun 7, 2018

Conversation

@kevinykuo
Copy link
Contributor

kevinykuo commented Mar 5, 2018

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Mar 5, 2018

Can you please add a bullet to NEWS? It should briefly describe the change (starting with name of the function), and crediting yourself with (@yourname, #issuenumber).

kevinykuo added 2 commits Mar 5, 2018
NEWS.md Outdated
@@ -1,5 +1,6 @@
# dbplyr 1.2.1.9000

This comment has been minimized.

Copy link
@hadley

hadley Mar 5, 2018

Member

Can you leave this as is please?

kevinykuo added 2 commits Mar 5, 2018
This reverts commit 101cd83.
@hadley hadley merged commit ae3e274 into tidyverse:master Jun 7, 2018
2 of 3 checks passed
2 of 3 checks passed
codecov/patch 0% of diff hit (target 77.7%)
Details
codecov/project 77.7% remains the same compared to 4e868ee
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Copy link
Member

hadley commented Jun 7, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.