Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing con argument in sql_render.op() #73

Merged
merged 5 commits into from Jun 7, 2018

Conversation

kevinykuo
Copy link
Contributor

@kevinykuo kevinykuo commented Mar 5, 2018

@hadley
Copy link
Member

@hadley hadley commented Mar 5, 2018

Can you please add a bullet to NEWS? It should briefly describe the change (starting with name of the function), and crediting yourself with (@yourname, #issuenumber).

NEWS.md Outdated
@@ -1,5 +1,6 @@
# dbplyr 1.2.1.9000
Copy link
Member

@hadley hadley Mar 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave this as is please?

@hadley hadley merged commit ae3e274 into tidyverse:master Jun 7, 2018
2 of 3 checks passed
@hadley
Copy link
Member

@hadley hadley commented Jun 7, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants