Align partialeval with dtplyr
#766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes a naming issue if `funs` is empty
This reverts commit a9abe44.
mgirlich
commented
Jan 21, 2022
mgirlich
commented
Jan 21, 2022
Closed
hadley
approved these changes
Feb 25, 2022
|
Thanks for working on this! |
Conflicts: R/partial-eval.R R/verb-pivot-longer.R R/verb-pivot-wider.R tests/testthat/_snaps/partial-eval.md tests/testthat/test-partial-eval.R
* rename `partial_eval_sym()` to `db_squash_sym()` * rename `partial_eval_call()` to `db_squash_call()`
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
Conflicts: R/verb-pivot-wider.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #760 and fixes #669.
This aligns the partial eval file with
dtplyrso that fixes and improvements can be transferred more easily from one to the other. Most functions are now basically identical. Still different:partial_eval()vsdt_squash()partial_eval_dots()vscapture_dots()partial_eval_call()vsdt_squash_call()partial_eval_across()vsdt_squash_across()dbplyrfunctions take avarsargument but it might make more sense to passdata(e.g. becauseacross()does not compute on group columns). Changing this would require changing the interface of the exported functionpartial_eval()but might still be worth it.