Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remote_name() #850

Merged
merged 8 commits into from
Apr 30, 2022
Merged

Fix remote_name() #850

merged 8 commits into from
Apr 30, 2022

Conversation

mgirlich
Copy link
Collaborator

Closes #639.

@mgirlich mgirlich mentioned this pull request Apr 29, 2022
Closed
@mgirlich mgirlich added this to the 2.2.0 milestone Apr 29, 2022
hadley
hadley approved these changes Apr 29, 2022
View reviewed changes
tests/testthat/test-remote.R Outdated Show resolved Hide resolved
krlmlr
krlmlr reviewed Apr 29, 2022
View reviewed changes
R/remote.R Outdated Show resolved Hide resolved
@mgirlich mgirlich merged commit 2c52e38 into main Apr 30, 2022
@mgirlich mgirlich deleted the fix-remote_name branch April 30, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlmlr krlmlr krlmlr left review comments

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

[question] expected output of x %>% dbplyr::compute() %>% dbplyr::remote_name()
3 participants
@mgirlich @hadley @krlmlr