Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in percent_rank()? #1132

Closed
jdthorpe opened this issue May 12, 2015 · 0 comments
Closed

Typo in percent_rank()? #1132

jdthorpe opened this issue May 12, 2015 · 0 comments

Comments

@jdthorpe
Copy link

@jdthorpe jdthorpe commented May 12, 2015

In trying to understand what 'percent_rank' does, I took a peak at the code and found the expression length(!is.na(x)). I can't think of any situation in which length(x) != length(!x) and I suspect that length() should be replaced with sum()

@hadley hadley closed this Aug 24, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants