Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

order_by does not handle something that is not a call #169

Closed
romainfrancois opened this issue Dec 24, 2013 · 0 comments
Closed

order_by does not handle something that is not a call #169

romainfrancois opened this issue Dec 24, 2013 · 0 comments
Assignees
Milestone

Comments

@romainfrancois
Copy link
Member

@romainfrancois romainfrancois commented Dec 24, 2013

order_by(10:1, cumsum(1:10))
#  [1] 55 54 52 49 45 40 34 27 19 10
> cx <- cumsum(1:10)
> order_by(10:1, cx)
Erreur : is.call(call) n'est pas TRUE

This causes things like this to fail:

right <- mutate(scrambled, running = order_by(year, cumsum(value)))

because cumsum is substituted internally with the hybrid evaluator.

It probably means that I need to come up with an internal hybrid version of order_by.

@ghost ghost assigned romainfrancois Jan 20, 2014
@hadley hadley added this to the 0.3 milestone Mar 17, 2014
@hadley hadley removed this from the v0.2 milestone Mar 17, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants