Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault in left_join when factor levels not equal #1712

Closed
adibender opened this issue Mar 14, 2016 · 1 comment
Closed

Segfault in left_join when factor levels not equal #1712

adibender opened this issue Mar 14, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@adibender
Copy link

@adibender adibender commented Mar 14, 2016

Similar to #371 (R --vanilla)

Minimal:

library(dplyr)
d1 <- iris[, c("Species", "Sepal.Length")]
d2 <- iris[, c("Species", "Sepal.Width")]
d2$Species <- factor(as.character(d2$Species), levels=rev(levels(d1$Species)))
left_join(d1, d2, by="Species")
@adibender adibender changed the title Segfault in left_join when factor levels not equal Segfault in left_join when factor levels not equal Mar 14, 2016
@hadley hadley added the bug label Apr 19, 2016
@hadley hadley added this to the 0.5 milestone Apr 19, 2016
@hadley
Copy link
Member

@hadley hadley commented Apr 19, 2016

@romainfrancois can you take a look at this too please?

romainfrancois added a commit that referenced this issue Apr 30, 2016
…just added a regression test. closes #1559
sicarul added a commit to sicarul/dplyr that referenced this issue May 4, 2016
sicarul added a commit to sicarul/dplyr that referenced this issue May 4, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants