Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal implementation of select #172

Closed
hadley opened this issue Jan 2, 2014 · 2 comments
Closed

Internal implementation of select #172

hadley opened this issue Jan 2, 2014 · 2 comments
Assignees
Milestone

Comments

@hadley
Copy link
Member

@hadley hadley commented Jan 2, 2014

To avoid making any copies of the columns (a la http://stackoverflow.com/questions/20886748)

@ghost ghost assigned romainfrancois Jan 2, 2014
@hadley
Copy link
Member Author

@hadley hadley commented Jan 20, 2014

Before implementing this, need to implement #158 and #192

@romainfrancois
Copy link
Member

@romainfrancois romainfrancois commented Feb 2, 2014

An easy enough way to handle this is to compute the names of the variables we want to keep on the R side and then pass the original data frame and these names down to some C++ function that will use shallow copying of the columns.

But we should I think keep the logic in R. I mean we could do #158 internally if we want, but that's not going to be very worth it.

hadley added a commit that referenced this issue Feb 4, 2014
@hadley hadley closed this in d948c6e Feb 4, 2014
@hadley hadley added this to the v0.1.2 milestone Feb 17, 2014
@hadley hadley removed this from the v0.2 milestone Feb 17, 2014
krlmlr pushed a commit to krlmlr/dplyr that referenced this issue Mar 2, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants