Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all_equal() behavior for more than one difference #1819

Closed
krlmlr opened this issue May 11, 2016 · 1 comment
Closed

all_equal() behavior for more than one difference #1819

krlmlr opened this issue May 11, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented May 11, 2016

> all.equal(data_frame(a=1, b=2), data_frame(a=1L, b=2L))
[1] "Incompatible type for column a: x numeric, y integerIncompatible type for column b: x numeric, y integer"

Should return a character vector instead.

Need to fix compatible_data_frame().

@hadley
Copy link
Member

@hadley hadley commented May 26, 2016

This would require quite a bit of re-engineering in the C++ code, and it's relatively low-priority so lets put off until the next version (unless you've already started on it)

Loading

@hadley hadley added this to the future milestone May 26, 2016
@krlmlr krlmlr self-assigned this Feb 10, 2017
@krlmlr krlmlr removed this from the future milestone Feb 10, 2017
@krlmlr krlmlr added this to the data frame 1 milestone Feb 10, 2017
@krlmlr krlmlr added this to the data frame 1 milestone Feb 10, 2017
@krlmlr krlmlr removed this from the future milestone Feb 10, 2017
@krlmlr krlmlr closed this in #2442 Feb 20, 2017
krlmlr added a commit to krlmlr/dplyr that referenced this issue Feb 20, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants