Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinct() problems for SQL sources #1937

Closed
krlmlr opened this issue Jun 18, 2016 · 0 comments
Closed

distinct() problems for SQL sources #1937

krlmlr opened this issue Jun 18, 2016 · 0 comments

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jun 18, 2016

  1. Doesn't seem to respect columns for SQL sources:

    > memdb_frame(a=1, b=2) %>% distinct(a, .keep_all = TRUE) %>% sql_render
    <SQL> SELECT DISTINCT *
    FROM `iksbzxasdl`

    Expected: SELECT DISTINCT(a)

  2. Error with .keep_all = FALSE for SQL sources seems unnecessary, could be implemented with a second SELECT:

    > memdb_frame(a=1, b=2) %>% distinct(a) %>% sql_render
    <SQL> SELECT a FROM (SELECT DISTINCT(a)
    FROM `iksbzxasdl`)
krlmlr pushed a commit to krlmlr/dplyr that referenced this issue Jun 18, 2016
@hadley hadley closed this in #1942 Jun 20, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant