Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and export probe_colwise_names #2129

Closed
jlegewie opened this issue Sep 17, 2016 · 1 comment
Closed

Rename and export probe_colwise_names #2129

jlegewie opened this issue Sep 17, 2016 · 1 comment
Assignees
Labels

Comments

@jlegewie
Copy link
Contributor

@jlegewie jlegewie commented Sep 17, 2016

It is easy to support other classes with methods for mutate_, summarise_, mutate_at etc. *_if() variants, however, do not work with databases and we are unable to directly support it in spatial objects in spdplyr. Here are some thoughts from @lionel- :

The easy fix is to make probe_colwise_names() an exported generic. I'm not sure we want to abstract out function mapping in the dplyr interface though. So I don't know what can be done here.

Maybe have a generic map in purrr. I think we need a s3map() family in purrr. But until purrr depends on dplyr (there are plans to decouple) we can't have dplyr depend on purrr anyway.

mdsumner/spdplyr#10 (comment)

@hadley
Copy link
Member

@hadley hadley commented Feb 21, 2017

Lets make probe_colwise_names() generic. We'll just need to come up with a slighter shorter name. It might be reasonable for the default method to call collect() or as.data.frame() (for data bases, n will need be set to a small number), since I think most often the predicates are used for type information.

@hadley hadley changed the title *_if() functions not based on generics Rename and export probe_colwise_names Feb 21, 2017
lionel- added a commit to lionel-/dplyr that referenced this issue Mar 24, 2017
lionel- added a commit to lionel-/dplyr that referenced this issue Mar 24, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants