Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output of check_supported_type() #2319

Closed
krlmlr opened this issue Dec 13, 2016 · 1 comment
Closed

Improve output of check_supported_type() #2319

krlmlr opened this issue Dec 13, 2016 · 1 comment
Labels

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 13, 2016

krlmlr@fe6bf8c#commitcomment-20176973

Perhaps include check for POSIXlt column.

@hadley: What should the error messages look like? Currently: Unsupported type CLOSXP for column "foo"

@hadley
Copy link
Member

@hadley hadley commented Dec 13, 2016

I'm not exactly sure but more like: Column `foo` is a function, not a vector

I'm not sure the best way of phrasing error messages:

  • Column `foo` is a function, not a vector
  • Column `foo` is not a vector (currently a function)
  • Column `foo` must be a vector, not a function

Maybe the last one?

@hadley hadley added the feature label Jan 31, 2017
@hadley hadley closed this in 790d3b9 Feb 26, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants