Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mojibake in error messages with column names on Windows #2441

Closed
krlmlr opened this issue Feb 19, 2017 · 1 comment
Closed

Mojibake in error messages with column names on Windows #2441

krlmlr opened this issue Feb 19, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 19, 2017

library(dplyr, warn.conflicts = FALSE)
a <- data_frame(a = 1)
names(a) <- "\u5e78"
b <- data_frame(a = 1)
names(b) <- "\u798f"
all.equal(a, b)
#> [1] "Cols in y but not x: �. Cols in x but not y: 幸. "

This will be easier to fix after #2388, look for get_cstring() -- perhaps this method should return string in native encoding.

@krlmlr krlmlr added this to the data frame 2 milestone Feb 21, 2017
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Mar 19, 2017

Need to define RCPP_USING_UTF8_ERROR_STRING and consequently use UTF-8 encoding internally.

Loading

@krlmlr krlmlr self-assigned this Mar 21, 2017
@krlmlr krlmlr closed this in #2545 Mar 21, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant