Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All error messages should mention the affected column(s) #2448

Closed
krlmlr opened this issue Feb 20, 2017 · 8 comments
Closed

All error messages should mention the affected column(s) #2448

krlmlr opened this issue Feb 20, 2017 · 8 comments
Labels

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 20, 2017

#2425 (comment)

@krlmlr krlmlr added the feature label Feb 20, 2017
@hadley
Copy link
Member

@hadley hadley commented Feb 22, 2017

Includes #2367 and #2438

Loading

@hadley
Copy link
Member

@hadley hadley commented Feb 26, 2017

And should not include the uninformative call site.

Loading

@hadley
Copy link
Member

@hadley hadley commented Mar 29, 2017

Also need to make sure that we're setting the call to R_NilValue() since it usually does not provide information that is helpful to the user.

Loading

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Mar 30, 2017

@hadley: I identified ~60 calls to stop() where a column name is missing, of which ~40 have no associated test. Okay to tackle only the tested calls, and leave the others for later (perhaps after #2311 and a round of coverage improvement)?

To remove the call site for C++ calls, we can tweak exception_to_r_condition() in RcppExport.cpp (via the END_RCPP macro). The function itself is provided by Rcpp, but I guess we can use some preprocessor hacks in dplyr_types.h.

Loading

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Mar 30, 2017

I'll double-check the linked issues, too.

Loading

@hadley
Copy link
Member

@hadley hadley commented Mar 30, 2017

Sounds good.

Loading

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Mar 31, 2017

@hadley: What formatting do we use for column names, classes, and function names? Currently, the preference seems: 'column', class, function_name. Should we be using backticks, double quotes, and trailing parentheses instead: `column`, "class", function_name()? Please advise.

Loading

@hadley
Copy link
Member

@hadley hadley commented Mar 31, 2017

I think:

  • `column`
  • Class can usually be bare, `x` is not a vector
  • I think I usually put functions in backticks too `between()` needs numeric inputs

Loading

krlmlr added a commit to krlmlr/dplyr that referenced this issue Apr 3, 2017
krlmlr added a commit to krlmlr/dplyr that referenced this issue Apr 9, 2017
krlmlr added a commit to krlmlr/dplyr that referenced this issue Apr 9, 2017
@krlmlr krlmlr closed this in #2606 Apr 11, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants