Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add '...' argument to sample_* generics #2888

Closed
hongooi73 opened this issue Jun 20, 2017 · 1 comment
Closed

feature request: add '...' argument to sample_* generics #2888

hongooi73 opened this issue Jun 20, 2017 · 1 comment

Comments

@hongooi73
Copy link

@hongooi73 hongooi73 commented Jun 20, 2017

This will allow a bit more flexibility when implementing custom methods for other data sources.

Eg for dplyrXdf, I'd like the ability to specify whether an exact sample size is required, along with the output format (data frame vs Xdf file):

sample_n.RxXdfData <- function(tbl, size=1, replace, weight, .env, .exact=TRUE, .outFile=tbl_xdf())
{
    ...
}
@lock
Copy link

@lock lock bot commented Jun 16, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jun 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants