Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(rename|select)_(at|if|all) functions should adapt grouping if necessary #3410

Closed
krlmlr opened this issue Mar 12, 2018 · 1 comment
Closed

(rename|select)_(at|if|all) functions should adapt grouping if necessary #3410

krlmlr opened this issue Mar 12, 2018 · 1 comment

Comments

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Mar 12, 2018

#3363 (comment), CC @lionel-:

Current behavior:

library(tidyverse)
tibble(a = 1, b = 2) %>% group_by(a) %>% rename_all(toupper)
#> # A tibble: 1 x 2
#> # Groups:   a [1]
#>       a     B
#>   <dbl> <dbl>
#> 1    1.    2.

Created on 2018-03-12 by the reprex package (v0.2.0).

Desired: Column a is renamed to A, the grouping is adapted.

We may want to implement this for the 0.7.5 release.

@krlmlr krlmlr changed the title (rename|select)_(at|if_all) functions should adapt grouping if necessary (rename|select)_(at|if|all) functions should adapt grouping if necessary Mar 16, 2018
@krlmlr krlmlr closed this in #3431 Mar 16, 2018
@lock
Copy link

@lock lock bot commented Sep 12, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant