Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joins segfault when by not specified and not found in both #371

Closed
otsaw opened this issue Apr 4, 2014 · 1 comment
Closed

Joins segfault when by not specified and not found in both #371

otsaw opened this issue Apr 4, 2014 · 1 comment

Comments

@otsaw
Copy link

@otsaw otsaw commented Apr 4, 2014

Impossible joins fail gracefully if by is specified (although something like "Column not found" would be a better error message)

> left_join(data.frame(x=1:5), data.frame(y=1:5), by="x")
Error: index out of bounds
> left_join(data.frame(x=1:5), data.frame(y=1:5), by="y")
Error: index out of bounds

but segfault when it needs to be guessed.

> left_join(data.frame(x=1:5), data.frame(y=1:5))
Joining by: character(0)

 *** caught segfault ***
address (nil), cause 'memory not mapped'

Traceback:
 1: .Call("dplyr_left_join_impl", PACKAGE = "dplyr", x, y, by)
 2: left_join_impl(x, y, by)
 3: left_join.tbl_df(tbl_df(x), y, by = by, copy = copy, ...)
 4: left_join(tbl_df(x), y, by = by, copy = copy, ...)
 5: as.data.frame(left_join(tbl_df(x), y, by = by, copy = copy, ...))
 6: left_join.data.frame(data.frame(x = 1:5), data.frame(y = 1:5))
 7: left_join(data.frame(x = 1:5), data.frame(y = 1:5))
@dayuhuang
Copy link

@dayuhuang dayuhuang commented Apr 4, 2014

Have the same issue.

Loading

romainfrancois added a commit that referenced this issue Apr 4, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants