Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of data_frame() by tibble() #4069

Closed
2 tasks
romainfrancois opened this issue Jan 2, 2019 · 2 comments
Closed
2 tasks

Replace uses of data_frame() by tibble() #4069

romainfrancois opened this issue Jan 2, 2019 · 2 comments
Labels
tidy-dev-day 馃 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@romainfrancois
Copy link
Member

romainfrancois commented Jan 2, 2019

This issue is to be dealt with on Tidyverse developer day 2019. 馃檹 don't submit pull requests for it outside of the event. We are of course interested in having this fixed, but much more interested in doing it as part of the developer day

  • identify uses of the deprecated function data_frame() in the dplyr codebase: code, docs, tests, vignette.
  • replace with uses of tibble()

Bonus: other 馃摝 might be using data_frame():

  • identify them, perhaps using gh to search github or maybe crandb
  • submit pull requests
@romainfrancois romainfrancois added the tidy-dev-day 馃 Tidyverse Developer Day rstd.io/tidy-dev-day label Jan 2, 2019
@Copepoda
Copy link
Contributor

Copepoda commented Jan 19, 2019

I'm working on this :)

@lock
Copy link

lock bot commented Jul 22, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tidy-dev-day 馃 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Development

No branches or pull requests

2 participants