group_by(.add) instead of group_by(add) #4137

romainfrancois · 2019-01-29T17:39:45Z

The add argument in group_by() is inconsistent with .add arguments in group_by_[if,at,all]().

We should eventually have only .add but for a (possibly long interim) we could have both add and .add = add

The text was updated successfully, but these errors were encountered:

In favour of correctly named .add argument. R CMD check doesn't check S3 method consistency for arguments after `...`, so this shouldn't cause problems with revdeps. Fixes #4137

romainfrancois added this to the 0.9.0 milestone Jan 30, 2019

hadley added feature grouping 👨‍👩‍👧‍👦 labels Dec 11, 2019

hadley added a commit that referenced this issue Jan 6, 2020

Deprecate group_by(..., add = TRUE)

40ba563

In favour of correctly named .add argument. R CMD check doesn't check S3 method consistency for arguments after `...`, so this shouldn't cause problems with revdeps. Fixes #4137

hadley mentioned this issue Jan 6, 2020

Deprecate group_by(..., add = TRUE) #4701

Merged

hadley closed this as completed in #4701 Jan 8, 2020

hadley added a commit that referenced this issue Jan 8, 2020

Deprecate group_by(..., add = TRUE) (#4701)

416bcd4

In favour of correctly named .add argument. R CMD check doesn't check S3 method consistency for arguments after `...`, so this shouldn't cause problems with revdeps. Fixes #4137

group_by(.add) instead of group_by(add) #4137

group_by(.add) instead of group_by(add) #4137

Comments

romainfrancois commented Jan 29, 2019