Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NA matching support in joins #4914

Closed
hadley opened this issue Mar 1, 2020 · 1 comment · Fixed by #4940
Closed

Update NA matching support in joins #4914

hadley opened this issue Mar 1, 2020 · 1 comment · Fixed by #4940
Labels
bug an unexpected problem or unintended behavior tables 🧮 joins and set operations
Milestone
1.0.0

Comments

@hadley
Copy link
Member

hadley commented Mar 1, 2020

Waiting on r-lib/vctrs#568

And deprecate use of pkgconfig, as I'm now confident that the current behaviour is the correct default for R.
@hadley hadley added bug an unexpected problem or unintended behavior tables 🧮 joins and set operations labels Mar 1, 2020
@hadley hadley added this to the 1.0.0 milestone Mar 1, 2020
@hadley
Copy link
Member Author

hadley commented Mar 1, 2020

No use of pkgconfig + na_matches in CRAN: https://github.com/search?q=org%3Acran+na_matches&type=Code

Looks like only two people used it on Github R code generally: https://github.com/search?l=R&p=9&q=na_matches&type=Code

hadley added a commit that referenced this issue Mar 5, 2020
@hadley
Use new na_equal argument to vec_match()/vec_in()
b6148b1 
Fixes #4914
@hadley hadley mentioned this issue Mar 5, 2020
Merged
@hadley hadley linked a pull request Mar 6, 2020 that will close this issue
Implement na_matches = "never" #4940
Merged
hadley added a commit that referenced this issue Mar 6, 2020
@hadley
Implement na_matches = "never" (#4940)
07f8896 
Fixes #4914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior tables 🧮 joins and set operations
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Implement na_matches = "never" tidyverse/dplyr
1 participant
@hadley