Deprecate support for filter(, <matrix with 1 column>)

[romainfrancois]

in #6083 we've let filter() handle matrices of 1 column for the time being. At some point this should warn, and then error.

Packages currently concerned:

• egor: dplyr 1.0.8 tilltnet/egor#76
• ggcharts: avoid matrices in filter() thomas-neitmann/ggcharts#100
• janitor: fix for dplyr 1.0.8 sfirke/janitor#463
• Momocs: update for dplyr 1.0.8 MomX/Momocs#222
• MRFcov: dplyr 1.0.8: avoid matrices in filter() nicholasjclark/MRFcov#32
• multifear: dplyr 1.0.8: avoid using matrices in filter() AngelosPsy/multifear#10
• psfmi: dplyr 1.0.8: avoid using matrices in filter() mwheymans/psfmi#5
• psycModel: dplyr 1.0.8 compatibility: avoid using matrices in filter() jasonmoy28/psycModel#8
• tangram.pipe
• TeachHist
• validata
• xpose

[hadley]

Minimal reprex:

library(dplyr, warn.conflicts = FALSE)

df <- tibble(x = 1:2, y = matrix(1:2, ncol = 1))
filter(df, y > 1)
#> # A tibble: 1 × 2
#>       x y[,1]
#>   <int> <int>
#> 1     2     2

df <- tibble(x = 1:2, y = matrix(1:2, ncol = 2))
filter(df, y > 1)
#> Error in `filter()`:
#> ! Problem while computing `..1 = y > 1`.
#> ✖ Input `..1` must be a logical vector, not a logical[,2].

^{Created on 2022-07-21 by the reprex package (v2.0.1)}

[hadley]

Slightly tricky because need to generate deprecation in C: https://github.com/tidyverse/dplyr/blob/main/src/filter.cpp#L67-L73

When fixing, should also update the other deprecations to use lifecycle: https://github.com/tidyverse/dplyr/blob/main/src/filter.cpp#L120-L125.