Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set operations need to follow same coercion rules #799

Closed
hadley opened this issue Nov 24, 2014 · 1 comment
Closed

Set operations need to follow same coercion rules #799

hadley opened this issue Nov 24, 2014 · 1 comment
Assignees
Labels
Milestone

Comments

@hadley
Copy link
Member

@hadley hadley commented Nov 24, 2014

df1 <- data_frame(x = 1:2, y = c(1, 1))
df1
df2 <- data_frame(x = 1:2, y = 1:2)
df2

intersect(df1, df2)
union(df1, df2)
setdiff(df1, df2)

I think we need to use the same rules in 4 places:

  • In these set operations
  • In the joins
  • In rbind_*
  • In combine()
@hadley hadley added the bug label Nov 24, 2014
@hadley hadley added this to the 0.3.1 milestone Nov 24, 2014
@hadley hadley added this to the 0.4 milestone Nov 24, 2014
@hadley hadley removed this from the 0.3.1 milestone Nov 24, 2014
@hadley
Copy link
Member Author

@hadley hadley commented Nov 24, 2014

Bumping this to 0.4 since it's probably quite a lot of work. But hopefully will eventually simplify the code

Loading

krlmlr pushed a commit to krlmlr/dplyr that referenced this issue Mar 2, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants