Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbind_list coverts ordered factors to factors #948

Closed
jnolis opened this issue Feb 6, 2015 · 1 comment
Closed

rbind_list coverts ordered factors to factors #948

jnolis opened this issue Feb 6, 2015 · 1 comment
Assignees
Milestone

Comments

@jnolis
Copy link

@jnolis jnolis commented Feb 6, 2015

If you have a variable in a data frame that is an ordered factor, after using an rbind_list call it gets converted into a regular factor. If the factors are the same in the different data frames being binded together, I don't think the ordered component of the factor should be removed.

y <- rbind_list(data.frame(x=factor(c(1,2,3),ordered=TRUE)),data.frame(x=factor(c(1,2,3),ordered=TRUE)))

class(y$x)
@romainfrancois romainfrancois self-assigned this Feb 7, 2015
@romainfrancois romainfrancois added this to the 0.5 milestone Feb 7, 2015
@romainfrancois
Copy link
Member

@romainfrancois romainfrancois commented Aug 24, 2015

This has been fixed. I've added a regression test for it anyway.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants