Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap order of dim_names and met_name in as.tbl_cube #1374

Merged
merged 3 commits into from Oct 22, 2015

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Sep 1, 2015

  • to make it consistent with the tbl_cube constructor
  • to allow adding a met_name argument to as.tbl_cube.data.frame later

Also, the met_name argument to as.tbl_cube.table now defaults to "Freq" for consistency with as.data.frame.table.

This is a breaking change, but perhaps justified since

tbl_cube support is currently experimental

@hadley
Copy link
Member

@hadley hadley commented Oct 21, 2015

Can you please move NEWS up?

Kirill Müller added 3 commits Oct 22, 2015
- to make it consistent with the `tbl_cube` constructor
- to allow adding a `met_name` argument to `as.tbl_cube.data.frame` later
@krlmlr krlmlr force-pushed the as.tbl_cube-consistency branch from 13fa2f7 to f0f9a54 Oct 22, 2015
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Oct 22, 2015

Rebased and moved news.

hadley added a commit that referenced this issue Oct 22, 2015
Swap order of dim_names and met_name in as.tbl_cube
@hadley hadley merged commit 671f08a into tidyverse:master Oct 22, 2015
1 check passed
@hadley
Copy link
Member

@hadley hadley commented Oct 22, 2015

Thanks!

@krlmlr krlmlr deleted the as.tbl_cube-consistency branch Mar 1, 2016
@lock
Copy link

@lock lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants