Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement as_data_frame.tbl_cube() #1563

Merged
merged 1 commit into from
Mar 1, 2016

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 2, 2015

as a simple wrapper of as.data.frame.tbl_cube(); converts dims to character variables.

With test.

@krlmlr
Copy link
Member Author

krlmlr commented Feb 19, 2016

Merged with master.

@hadley
Copy link
Member

hadley commented Mar 1, 2016

I guess this should now go in tibble?

@krlmlr
Copy link
Member Author

krlmlr commented Mar 1, 2016

If tbl_cube is a dplyr concept, I think this belongs here.

@hadley
Copy link
Member

hadley commented Mar 1, 2016

Yeah, you're right. Would you mind squashing this?

as a simple wrapper of as.data.frame.tbl_cube(stringsAsFactor = FALSE). With test.
@krlmlr
Copy link
Member Author

krlmlr commented Mar 1, 2016

Squashed.

hadley added a commit that referenced this pull request Mar 1, 2016
@hadley hadley merged commit 94efd2f into tidyverse:master Mar 1, 2016
@hadley
Copy link
Member

hadley commented Mar 1, 2016

Thanks!

@lock
Copy link

lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants