Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JoinVisitorImpl.h #1582

Merged
merged 2 commits into from Mar 8, 2016
Merged

Update JoinVisitorImpl.h #1582

merged 2 commits into from Mar 8, 2016

Conversation

@joel23888
Copy link
Contributor

@joel23888 joel23888 commented Dec 11, 2015

Add virtual class POSIXt to class of join result to fix #1578.

Add virtual class POSIXt to class of join result.
@hadley
Copy link
Member

@hadley hadley commented Mar 1, 2016

Would you mind adding a test for this?

Loading

Test result of joining POSIXct is POSIXct (tidyverse#1578)
@joel23888
Copy link
Contributor Author

@joel23888 joel23888 commented Mar 2, 2016

I added a test but the Travis build returned an error, which I am not sure about.

Loading

@hadley hadley merged commit 2b0765b into tidyverse:master Mar 8, 2016
1 check failed
Loading
@hadley
Copy link
Member

@hadley hadley commented Mar 8, 2016

Thanks!

Loading

@lock
Copy link

@lock lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

Loading

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants