Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Work around match() problem in R 3.3.0 #1810

Closed
wants to merge 5 commits into from

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented May 10, 2016

Fixes #1806.

Kirill Müller added 5 commits May 9, 2016
- also evaluate in base environment, not in the global environment
this might introduce a slowdown if the symbol map is used in a tight loop
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented May 11, 2016

Parts of this are useful either way, but the fix consists of disabling the optimization (see #1806) and is only necessary for R 3.3.0.

@krlmlr krlmlr changed the title Work around match() problem in R 3.3.0 WIP: Work around match() problem in R 3.3.0 May 11, 2016
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented May 11, 2016

Look for R_version in R-exts to make this conditional to the R version.

@hadley hadley closed this in 7168759 May 26, 2016
@hadley
Copy link
Member

@hadley hadley commented May 26, 2016

Thanks!

@krlmlr krlmlr deleted the feature/1806-match-workaround branch May 26, 2016
@krlmlr krlmlr mentioned this pull request Jun 4, 2016
@lock
Copy link

@lock lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants