Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all_equal() fixes #1820

Merged
merged 8 commits into from Jun 1, 2016
Merged

all_equal() fixes #1820

merged 8 commits into from Jun 1, 2016

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented May 11, 2016

  • legible error message for raw types which cannot be handled currently
  • show message if types are incompatible and convert = TRUE
  • tests
@hadley
Copy link
Member

@hadley hadley commented May 11, 2016

LGTM

@hadley
Copy link
Member

@hadley hadley commented May 26, 2016

Can you please squash? (That'll also rerun travis now that everything is working again)

@hadley
Copy link
Member

@hadley hadley commented May 27, 2016

I think this needs some changes post #1815 - px and py can never be zero now.

I also see

df <- data_frame(a = 1:3, b = as.raw(1:3))
all.equal(df, df)
#> Unsupported vector type 0x7fef4b05a528

And I can't figure out why - the code in subset_visitor() looks fine to me.

@hadley hadley added this to the 0.5 milestone May 27, 2016
@hadley
Copy link
Member

@hadley hadley commented May 31, 2016

@hadley
Copy link
Member

@hadley hadley commented May 31, 2016

Do you have time to merge/rebase in the next couple of days? If not, no problems, but I'll probably do myself (just to get everything squared away for the dplyr release)

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented May 31, 2016

I'll do this by tomorrow.

@krlmlr krlmlr force-pushed the feature/equal-raw branch 2 times, most recently from e1e3126 to f5dedb2 May 31, 2016
@krlmlr krlmlr force-pushed the feature/equal-raw branch from 990b1cc to 9d64b06 Jun 1, 2016
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jun 1, 2016

Done.

@hadley hadley merged commit 98a8991 into tidyverse:master Jun 1, 2016
2 of 3 checks passed
@hadley
Copy link
Member

@hadley hadley commented Jun 1, 2016

Thanks!

@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants