Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: as_data_frame() on SQL sources #1821

Merged
merged 5 commits into from Jun 1, 2016

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented May 11, 2016

  • now defaults to n = Inf (no progress bar yet)
  • with tests

Fixes #1752.

@hadley
Copy link
Member

@hadley hadley commented May 26, 2016

Can you please add a bullet to NEWS and I'll merge

@hadley hadley added this to the 0.5 milestone May 27, 2016
@hadley hadley added this to the 0.5 milestone May 27, 2016
@krlmlr krlmlr force-pushed the feature/1752-as-data-frame branch from 1960dab to f560bf5 Jun 1, 2016
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jun 1, 2016

Rebased, added NEWS. Interruptable chunked fetch with progress indicator isn't there yet, but perhaps this should be a helper function in DBI or elsewhere?

@hadley hadley merged commit ae60a47 into tidyverse:master Jun 1, 2016
3 checks passed
@hadley
Copy link
Member

@hadley hadley commented Jun 1, 2016

Yeah, lets talk about an API for that in DBI.

@krlmlr krlmlr deleted the feature/1752-as-data-frame branch Jun 1, 2016
@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants