Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RStudio project settings to install tests #1952

Merged
merged 1 commit into from Aug 24, 2016

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jun 21, 2016

for tidyverse/dtplyr#24.

@hadley
Copy link
Member

@hadley hadley commented Jun 23, 2016

I could've sworn there was a global option/env var that let you choose this for all installs

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jun 23, 2016

I haven't found it. Does your RStudio append --install-tests when you press Cmd + Shift + B?

@hadley
Copy link
Member

@hadley hadley commented Jun 23, 2016

An R option, not an RStudio option

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jun 23, 2016

There's the devtools.install.args option, but RStudio Preview 0.99.1230 doesn't use it for build + install. It's used for devtools::install(), but that function installs tests by default. R itself seems to look exclusively for the --install-tests switch: https://github.com/wch/r-source/blob/5cfd0944cb9a7554c597342c8274e556bbd5df91/src/library/tools/R/install.R#L1375.

Could RStudio just call devtools::install() for build + install?

@hadley
Copy link
Member

@hadley hadley commented Aug 24, 2016

LGTM

@krlmlr krlmlr merged commit 0f56316 into tidyverse:master Aug 24, 2016
1 check failed
@krlmlr krlmlr deleted the f-proj-settings branch Aug 24, 2016
@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants