Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zero-column corner case in vector visitors #1959

Merged
merged 5 commits into from Jun 23, 2016

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jun 23, 2016

  • hash(): return index
  • nrows(): stop() instead of segfault

Fixes #1957.

With tests, which pass locally. Travis fails because of tibble update (#1949).

Currently I have no idea how to make the forward of n_distinct() to n() explicit in the code for hybrid evaluation.

@krlmlr krlmlr force-pushed the b-1957-n-distinct-zero branch from 7a368ab to 6b3b302 Jun 23, 2016
@hadley
Copy link
Member

@hadley hadley commented Jun 23, 2016

I think I would prefer to make this an error, rather than switching to n() behaviour

@krlmlr krlmlr force-pushed the b-1957-n-distinct-zero branch from 6b3b302 to ecd6012 Jun 23, 2016
@hadley hadley merged commit 95822df into tidyverse:master Jun 23, 2016
2 of 3 checks passed
@hadley
Copy link
Member

@hadley hadley commented Jun 23, 2016

Thanks!

@krlmlr krlmlr deleted the b-1957-n-distinct-zero branch Jun 23, 2016
@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants