New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem that group_by() cannot handle UTF-8 column names on Windows #2058

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@r-suzuki

r-suzuki commented Aug 9, 2016

Hi, this is just a workaround to the issue #2005 (and possibly related to #1555). With this fix the following example works properly:

library(dplyr)
data(iris)
iris %>%
    mutate(品種 = Species) %>%
    group_by(品種) %>%
    summarise(avg = mean(Sepal.Length))

It would be preferable to fix build_index_cpp to handle multiple encodings, however this workaround is simple and works as expected.

@r-suzuki r-suzuki changed the title from Fix the problem that group_by() cannot handle UTF-8 column names to Fix the problem that group_by() cannot handle UTF-8 column names on Windows Aug 9, 2016

@krlmlr

This comment has been minimized.

Member

krlmlr commented Nov 7, 2016

Thanks. My plan is to fix this at a more general scope as part of #1950.

@r-suzuki

This comment has been minimized.

r-suzuki commented Nov 8, 2016

Thanks @krlmlr , general fix is more appreciated. This problem seems to need a fix in base-R so I ended up with just a workaround here.

This encoding problem is the main reason that I cannot use dplyr in our projects, so any fix would be far better than nothing. I hope there is any solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment