Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce integer 'n' for lag() #2162

Merged
merged 1 commit into from Dec 6, 2016
Merged

enforce integer 'n' for lag() #2162

merged 1 commit into from Dec 6, 2016

Conversation

@kevinushey
Copy link
Contributor

@kevinushey kevinushey commented Oct 5, 2016

This resolves an issue in stricter SQL engines where double values are not accepted.

This resolves an issue in stricter SQL engines where `double` values are not accepted.
@hadley
Copy link
Member

@hadley hadley commented Dec 2, 2016

LGTM. News bullet please?

@krlmlr krlmlr merged commit 5baf524 into tidyverse:master Dec 6, 2016
4 checks passed
@krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 6, 2016

Thanks! I'll update NEWS.

@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants