Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid tests #2306

Merged
merged 9 commits into from Dec 10, 2016
Merged

Hybrid tests #2306

merged 9 commits into from Dec 10, 2016

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 10, 2016

Extracted from #2298, will implement argument matching and constant folding after this is merged. @hadley: PTAL.

Fixes #1691.

krlmlr added 7 commits Dec 10, 2016
…nery

- use f_capture()

- special-case enclosing list() call
- test n() and n_distinct()

- improve %in% tests

- test min() and max()

- test first(), last(), and nth()

- improve nth() tests

- test lead() and lag()

- test mean(), var(), sd() and sum()

- test row_number(), ntile(), min_rank(), percent_rank(), dense_rank(), and cume_dist()

- test complex numbers

- test call matching

- constfold-related test

- test nesting of hybrid handlers

- add failing test
use typeof() instead of class()

keep treating n as numeric, it is a numeric anyway after trunc()
@hadley
Copy link
Member

@hadley hadley commented Dec 10, 2016

LGTM

@krlmlr krlmlr merged commit 3ae8a0a into tidyverse:master Dec 10, 2016
0 of 2 checks passed
@krlmlr krlmlr deleted the f-#1691-hybrid-tests branch Dec 10, 2016
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Dec 12, 2016

@lionel-: This tests what the hybrid evaluator currently can and cannot do.

@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants