Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tribble to imported objects #2336

Closed
wants to merge 1 commit into from
Closed

Conversation

@chrMongeau
Copy link
Contributor

@chrMongeau chrMongeau commented Dec 19, 2016

The tibble package states that "frame_data() is an older name for tribble(). It will eventually be phased out." (See: https://github.com/tidyverse/tibble/blob/2ba09826536ec33f4fb7b2edde146f19c99d95bd/man/tribble.Rd#L25-L26 ) This commit adds tribble to the imported objects from tibble.

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 20, 2016

@hadley: Exporting tribble() looks sensible to me. OK?

@hadley
Copy link
Member

@hadley hadley commented Dec 20, 2016

LGTM

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 20, 2016

@chrMongeau: Thanks. Could you please

  • run devtools::document() with the latest development version of roxygen2 installed
  • add a bullet to NEWS

@chrMongeau
Copy link
Contributor Author

@chrMongeau chrMongeau commented Dec 20, 2016

@krlmlr: Of course, thank you. devtools::document() was done and a notice to NEWS.md was added.

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 20, 2016

Thanks. I've updated my local roxygen2 version and ran document() myself to get rid of the many empty-line changes. Could you please rebase and force-push, and also include the issue number and your GitHub handle in the NEWS entry?

The `tibble` package states that "frame_data() is an older name for tribble(). It will eventually be phased out." (See: https://github.com/tidyverse/tibble/blob/2ba09826536ec33f4fb7b2edde146f19c99d95bd/man/tribble.Rd#L25-L26 ) This commit adds `tribble` to the imported objects from `tibble`.
@chrMongeau
Copy link
Contributor Author

@chrMongeau chrMongeau commented Dec 21, 2016

@krlmlr: Done. Added note, rebased and force-pushed.

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 21, 2016

Thanks. Closed in 7bb5652.

@krlmlr krlmlr closed this Dec 21, 2016
@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants