Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New group_names() to return group names as character vector #2384

Merged
merged 11 commits into from Feb 10, 2017

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 27, 2017

in groups(). This is a breaking change, in preparation for #1950.

@hadley: PTAL.

@hadley
Copy link
Member

@hadley hadley commented Jan 27, 2017

Hmmmm, this is going to break every backend, and coordinating the changes is going to be hard. What if we made a new generic group_vars() (?) instead? It could have a default method that did lapply(groups(x), as.character) with a message/warning.

@hadley
Copy link
Member

@hadley hadley commented Jan 27, 2017

@krlmlr do you have thoughts on how your API diffing package might handle this? It seems like you'd need some manual tags to flag changes in data types.

@krlmlr krlmlr force-pushed the f-groups-character branch 2 times, most recently from f40ad3f to 07adf59 Jan 27, 2017
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jan 27, 2017

@hadley: Added group_vars() generic instead, also using it internally. Could you please also look at #2382?

@krlmlr krlmlr force-pushed the f-groups-character branch 2 times, most recently from 07168e6 to f3d7fb8 Jan 27, 2017
@krlmlr krlmlr mentioned this pull request Jan 27, 2017
@krlmlr krlmlr changed the title Return group names as character vector New group_names() to return group names as character vector Feb 1, 2017
@krlmlr krlmlr force-pushed the f-groups-character branch from d00923b to a62ad73 Feb 9, 2017
@krlmlr krlmlr force-pushed the f-groups-character branch from a62ad73 to bb6fdfb Feb 9, 2017
@krlmlr krlmlr force-pushed the f-groups-character branch from 425891e to f4aca07 Feb 9, 2017
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Feb 9, 2017

Added tests. @hadley: PTAL.

hadley
hadley approved these changes Feb 9, 2017
@krlmlr krlmlr merged commit d9ad3f0 into tidyverse:master Feb 10, 2017
4 checks passed
@krlmlr krlmlr deleted the f-groups-character branch Feb 10, 2017
@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants