Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New check_length(), and improved error messages for mutate expressions that return NULL #2439

Merged
merged 8 commits into from Feb 20, 2017

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 19, 2017

a more general version of check_length_one().

Fixes #2187.

@hadley: PTAL.

@krlmlr krlmlr changed the title New check_length() New check_length(), and improved error messages for mutate expressions that return NULL Feb 19, 2017
hadley
hadley approved these changes Feb 20, 2017
Copy link
Member

@hadley hadley left a comment

In the future, we'll probably want to include a variable name column.

I'd have a slight preference for checks.h rather than check_length.h as that will make it easier to see all error messages and keep their grammar consistent.

@krlmlr krlmlr merged commit dd96f3c into tidyverse:master Feb 20, 2017
0 of 2 checks passed
@krlmlr krlmlr deleted the f-incompatible-mutate branch Feb 20, 2017
@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants