Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ungrouped summarise() uses summary variables correctly #2453

Merged
merged 3 commits into from Feb 20, 2017

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 20, 2017

@hadley: This is just a hack. Not all variables passed to input() are summary variables, but we're on the safe side if we assume they are. (In the worst case, standard instead of hybrid evaluation is used, this doesn't matter for ungrouped data.)

A clean fix would be to treat the ungrouped case as a special case for just one group (#2311). This would simplify the codebase a lot and also make the behavior more consistent. I have started the implementation, but I'll need more time.

Fixes #2404.

@krlmlr krlmlr requested a review from hadley Feb 20, 2017
hadley
hadley approved these changes Feb 20, 2017
@krlmlr krlmlr merged commit 9b950e8 into tidyverse:master Feb 20, 2017
0 of 2 checks passed
Loading
@krlmlr krlmlr deleted the b-#2404-overwrite-ungrouped-summary branch Feb 20, 2017
@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

Loading

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants