Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add difftime support to combine and bind_rows #2486

Closed
wants to merge 2 commits into from

Conversation

zeehio
Copy link
Contributor

@zeehio zeehio commented Mar 2, 2017

  • We are already supporting mutate with difftime variables.
  • I'm preparing a PR to make mutate use Collecter.h (sharing the coercion rules and algorithm used by combine and bind_rows).
  • To preserve backwards compatibility in mutate with difftime objects I need Collecter.h to support difftime objects.

This is the first out of two PRs for #1892. The next PR will depend on this one but this can be reviewed (and merged) already (improves dplyr compatibility).

We want to support difftime in bind_rows and combine.

We are already supporting mutate and I'm preparing a PR
to make mutate use Collecter.h as well.
@hadley
Copy link
Member

hadley commented Mar 2, 2017

Can you take a look at the failure on oldrel please? You might need to generate the expected output directly, rather than relying on c

@zeehio
Copy link
Contributor Author

zeehio commented Mar 2, 2017

Done

@krlmlr
Copy link
Member

krlmlr commented Mar 2, 2017

I reviewed the other PR before this. Can you rebase so that this PR uses the same commits as the other, so that the comments are carried over here?

@krlmlr
Copy link
Member

krlmlr commented Mar 2, 2017

Oh, it does already :-(

@zeehio
Copy link
Contributor Author

zeehio commented Mar 2, 2017

Let's work on the other PR directly.

@zeehio zeehio closed this Mar 2, 2017
@zeehio zeehio deleted the add_difftime_collecter branch February 18, 2018 17:59
@lock
Copy link

lock bot commented Aug 17, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Aug 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants