Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of join code #2514

Merged
merged 9 commits into from Mar 9, 2017
Merged

Cleanup of join code #2514

merged 9 commits into from Mar 9, 2017

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Mar 8, 2017

in preparation for #2033. Considerably simplifies string-string and string-factor joins.

Fixes #1858.

krlmlr added 6 commits Mar 8, 2017
- always expand factor to character vector
- join compares and hashes `CHARSXP` instead of matching via `r_match()`, no special handling needed!
- now relying on declared encoding, converting to UTF-8 if necessary
@krlmlr krlmlr requested a review from hadley Mar 8, 2017
hadley
hadley approved these changes Mar 9, 2017
@krlmlr krlmlr merged commit 8ac9d1e into tidyverse:master Mar 9, 2017
0 of 2 checks passed
@krlmlr krlmlr deleted the f-#2033-cleanup-joins branch Mar 9, 2017
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Mar 21, 2017

@hadley: This gives a ~3-4x speedup for joining strings, if they don't need to be reencoded.

download

@hadley
Copy link
Member

@hadley hadley commented Mar 22, 2017

Nice!

)
}

if (R_version != R.version.string) {
Copy link
Member

@hadley hadley May 19, 2017

Do you remember why you added this check here?

Copy link
Member Author

@krlmlr krlmlr May 19, 2017

We're checking the R version at compile time, currently only for a workaround for a problem in R 3.3.0 .

@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants