Cleanup of join code #2514
Merged
Cleanup of join code #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- always expand factor to character vector - join compares and hashes `CHARSXP` instead of matching via `r_match()`, no special handling needed! - now relying on declared encoding, converting to UTF-8 if necessary
hadley
approved these changes
Mar 9, 2017
|
@hadley: This gives a ~3-4x speedup for joining strings, if they don't need to be reencoded.
|
|
Nice! |
hadley
reviewed
May 19, 2017
| ) | ||
| } | ||
|
|
||
| if (R_version != R.version.string) { |
There was a problem hiding this comment.
Do you remember why you added this check here?
There was a problem hiding this comment.
We're checking the R version at compile time, currently only for a workaround for a problem in R 3.3.0 .
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in preparation for #2033. Considerably simplifies string-string and string-factor joins.
Fixes #1858.