Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix very rare case of false match during join #2515

Merged
merged 2 commits into from Mar 9, 2017

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Mar 9, 2017

Under the following conditions, a false match during a join could have occurred theoretically:

  • Joining an integer and a numeric column
  • Two numeric values have the same integer component but different fractional components, and hash to the same value

It is unlikely that this has been ever observed, but it might be possible to construct an artificial example.

@krlmlr krlmlr requested a review from hadley Mar 9, 2017
@krlmlr krlmlr merged commit d350569 into tidyverse:master Mar 9, 2017
0 of 2 checks passed
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Mar 9, 2017

Merging, because further changes depend on this.

@krlmlr krlmlr deleted the b-#2033-fix-lhs-rhs branch Mar 9, 2017
@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant