New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix join warnings #2741

Merged
merged 4 commits into from May 4, 2017

Conversation

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented May 4, 2017

  • New Column class
  • Remove duplicate warnings
  • Warn about inconsistencies in semi- and anti-joins
  • Reverse order of column names in warnings for left join

Closes #2733. Fixes #2739.

krlmlr added some commits May 4, 2017

fix warnings
- warn about inconsistencies in semi- and anti-joins
- reverse order of column names in warnings for left join

@krlmlr krlmlr requested review from hadley and removed request for hadley May 4, 2017

@krlmlr krlmlr force-pushed the krlmlr:b-#2733-#2739-join-warn branch from 3151adf to eeba943 May 4, 2017

@hadley

hadley approved these changes May 4, 2017

Can you briefly describe where the second warning was coming from? I assume it's something to do with passing warn_ = false in the right place

@@ -30,7 +30,7 @@ DataFrame subset_join(DataFrame x, DataFrame y,
}
// first the joined columns
DataFrameJoinVisitors join_visitors(x, y, SymbolVector(by_x), SymbolVector(by_y), false, false);
DataFrameJoinVisitors join_visitors(x, y, SymbolVector(by_x), SymbolVector(by_y), true, false);

This comment has been minimized.

@krlmlr

krlmlr May 4, 2017

Member

@hadley. We're now warning only from here, used to warn from the individual join functions below (with flipped col names for left join), and from both constructors for the new warnings you added.

@krlmlr krlmlr merged commit 354b085 into tidyverse:master May 4, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@krlmlr krlmlr deleted the krlmlr:b-#2733-#2739-join-warn branch May 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment