Fix join warnings #2741
Merged
Fix join warnings #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- warn about inconsistencies in semi- and anti-joins - reverse order of column names in warnings for left join
krlmlr
force-pushed
the
b-#2733-#2739-join-warn
branch
from
3151adf
to
eeba943
Compare
hadley
approved these changes
May 4, 2017
krlmlr
commented
May 4, 2017
| @@ -30,7 +30,7 @@ DataFrame subset_join(DataFrame x, DataFrame y, | |||
| } | |||
|
|
|||
| // first the joined columns | |||
| DataFrameJoinVisitors join_visitors(x, y, SymbolVector(by_x), SymbolVector(by_y), false, false); | |||
| DataFrameJoinVisitors join_visitors(x, y, SymbolVector(by_x), SymbolVector(by_y), true, false); | |||
There was a problem hiding this comment.
@hadley. We're now warning only from here, used to warn from the individual join functions below (with flipped col names for left join), and from both constructors for the new warnings you added.
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ColumnclassCloses #2733. Fixes #2739.