New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tbl_df always inherits from tbl #2789

Merged
merged 3 commits into from May 17, 2017

Conversation

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented May 16, 2017

Fixes tidyverse/tibble#256.

Ideally, classes_grouped() and classes_not_grouped() should be exported functions and called throughout, maybe later.

@krlmlr krlmlr requested a review from hadley May 16, 2017

krlmlr added some commits May 16, 2017

@krlmlr

This comment has been minimized.

Member

krlmlr commented May 16, 2017

@hadley: We might want to add a safety net to tibble, but the CRAN submission is underway. If we don't, this affects users who create classes that inherit from tbl_df but not tbl. Please advise.

@hadley

hadley approved these changes May 16, 2017

@krlmlr krlmlr merged commit 33d5236 into tidyverse:master May 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@krlmlr krlmlr deleted the krlmlr:b-rowwise-classes branch May 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment