New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assigment of NA_REAL to LogicalVector #2855

Merged
merged 3 commits into from Jun 13, 2017

Conversation

Projects
None yet
3 participants
@zeehio
Copy link
Contributor

zeehio commented Jun 13, 2017

Catched by https://cran.r-project.org/web/checks/check_results_dplyr.html (undefined behaviour sanitizer)

@krlmlr

This comment has been minimized.

Copy link
Member

krlmlr commented Jun 13, 2017

Awesome, thanks. Could you add a NEWS bullet, please?

@zeehio

This comment has been minimized.

Copy link
Contributor Author

zeehio commented Jun 13, 2017

Thanks for the review. Done 👍

@krlmlr krlmlr requested a review from hadley Jun 13, 2017

NEWS.md Outdated
@@ -1,3 +1,9 @@
# dplyr 0.7.0.9000

## Bug fixes

This comment has been minimized.

@hadley

hadley Jun 13, 2017

Member

Can you remove this please? It's easier to figure out what the second level headings should be just before release

This comment has been minimized.

@zeehio

zeehio Jun 13, 2017

Author Contributor

Done. 👍

@hadley hadley merged commit 7da43c8 into tidyverse:master Jun 13, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@hadley

This comment has been minimized.

Copy link
Member

hadley commented Jun 13, 2017

Thanks!

@zeehio zeehio deleted the zeehio:patch-1 branch Feb 18, 2018

@lock

This comment has been minimized.

Copy link

lock bot commented Aug 17, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Aug 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.