Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ungrouped mutate() doesn't mark new or overwritten variables as summaries #2869

Merged
merged 3 commits into from Jun 15, 2017

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jun 14, 2017

Regression introduced in 0.7.0, probably in #2453.

Fixes #2842, fixes #2856.

@hadley
Copy link
Member

@hadley hadley commented Jun 14, 2017

Looks good. Just needs one of those test cases.

Loading

hadley
hadley approved these changes Jun 14, 2017
@krlmlr krlmlr merged commit 64ae0f8 into tidyverse:master Jun 15, 2017
1 of 2 checks passed
Loading
@krlmlr krlmlr deleted the b-#2842-mutate-reuse branch Jun 15, 2017
@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

Loading

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants