Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protection error when constructing error messages #2877

Merged
merged 1 commit into from Jun 16, 2017

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jun 15, 2017

I have no idea why I used wrap() originally, but this results in a naked SEXP which may be destroyed even before the function is called. Tests with gctorture are still running.

because this is a protection error
@krlmlr krlmlr requested a review from hadley Jun 15, 2017
@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jun 16, 2017

I don't see any of the errors I saw before when running alll tests with gctorture.

hadley
hadley approved these changes Jun 16, 2017
@krlmlr krlmlr merged commit 2b82798 into tidyverse:master Jun 16, 2017
1 of 2 checks passed
@krlmlr krlmlr deleted the b-protect-bad branch Jun 16, 2017
@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants