New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on Rcpp >= 0.12.7 #2914

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
2 participants
@zeehio
Copy link
Contributor

zeehio commented Jun 26, 2017

This line in dplyr https://github.com/tidyverse/dplyr/blob/master/inst/include/tools/SymbolString.h#L21 uses Rcpp::String::String(const char*, cetype_t), available in Rcpp since this commit RcppCore/Rcpp@0bf8e97 that was included in 0.12.7.

That's why dplyr needs to depend on Rcpp 0.12.7 instead of 0.12.6.

Closes #2902

Depend on Rcpp >= 0.12.7
This line in dplyr https://github.com/tidyverse/dplyr/blob/master/inst/include/tools/SymbolString.h#L21 uses `Rcpp::String::String(const char*, cetype_t)`, available in Rcpp since this commit RcppCore/Rcpp@0bf8e97 that was included in 0.12.7.

That's why dplyr needs to depend on Rcpp 0.12.7.

Closes #2902

@krlmlr krlmlr merged commit 66232e9 into tidyverse:master Jul 13, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 4bb35fb...f4a5361
Details
codecov/project 80.79% (target 70%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@krlmlr

This comment has been minimized.

Copy link
Member

krlmlr commented Jul 13, 2017

Thanks!

@zeehio zeehio deleted the zeehio:patch-2 branch Feb 18, 2018

@lock

This comment has been minimized.

Copy link

lock bot commented Aug 17, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Aug 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.