Support zero-length vectors in case_when() #3048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Aug 23, 2017
tests/testthat/test-case-when.R
Outdated
| @@ -32,7 +32,7 @@ test_that("cases must yield compatible lengths", { | |||
| c(TRUE, FALSE) ~ 1, | |||
| c(FALSE, TRUE, FALSE) ~ 2 | |||
| ), | |||
| "LHS of case 1 (`c(TRUE, FALSE)`) must be length 3 (the longest input) or one, not 2", | |||
| "All conditions and values must be length 1 or 2 (the first non-atomic value), not 3", | |||
There was a problem hiding this comment.
I'd say remove the parenthetical ("(the first non-atomic value)") and be more precise about the failures:
All conditions and values must be length 1 or 2.
Problems at the following locations: 2.
|
@hadley: The error message now quotes the failing arguments verbatim, for consistency with other error messages. |
hadley
approved these changes
Aug 23, 2017
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3041.
The second commit is optional, it simplifies error handling but the message is less verbose.