Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slice() for negative indices #3073

Merged
merged 4 commits into from Sep 5, 2017
Merged

Fix slice() for negative indices #3073

merged 4 commits into from Sep 5, 2017

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Sep 3, 2017

if the range stretches over the number-of-rows boundary.

Fixes downstream problems with waccR.

@krlmlr krlmlr requested a review from hadley Sep 3, 2017
hadley
hadley approved these changes Sep 5, 2017
src/slice.cpp Outdated
@@ -66,7 +66,7 @@ DataFrame slice_grouped(GroupedDataFrame gdf, const QuosureList& dots) {
Call call(quosure.expr());

std::vector<int> indx;
indx.reserve(1000);
Copy link
Member

@hadley hadley Sep 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to change?

Loading

Copy link
Member Author

@krlmlr krlmlr Sep 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't, removed. We should take another look as part of #2311.

Loading

@krlmlr krlmlr merged commit aeedbab into tidyverse:master Sep 5, 2017
4 checks passed
Loading
@krlmlr krlmlr deleted the b-slice-oob branch Sep 5, 2017
@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

Loading

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants